Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in SurveyDesign docstring #285

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

nadiaenh
Copy link
Collaborator

@nadiaenh nadiaenh commented Mar 20, 2023

Removed stype argument, as apiclus1 is not stratified.
Checked all files in the src folder, they did not contain this mistake.
Closes issue #282

Removed stype argument, as apiclus1 is not stratified.
@codecov-commenter
Copy link

Codecov Report

Merging #285 (c13b81c) into main (7d24325) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          187       187           
=========================================
  Hits           187       187           
Impacted Files Coverage Δ
src/SurveyDesign.jl 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ayushpatnaikgit ayushpatnaikgit linked an issue Mar 20, 2023 that may be closed by this pull request
@ayushpatnaikgit
Copy link
Member

Closes #282

@ayushpatnaikgit
Copy link
Member

ayushpatnaikgit commented Mar 20, 2023

Have you run julia docs/make.jl and tested it? The CI is complaining a bit.

Copy link
Member

@ayushpatnaikgit ayushpatnaikgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctest is failing. DataFrame size is incorrect.

@ayushpatnaikgit ayushpatnaikgit self-requested a review March 20, 2023 23:46
@ayushpatnaikgit ayushpatnaikgit dismissed their stale review March 20, 2023 23:46

Docttest is failing. DataFrame size is incorrect.

changed df columns to 44 instead of 43
@ayushpatnaikgit ayushpatnaikgit merged commit ed8d172 into xKDR:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in apiclus1 example in documentation.
3 participants